You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/16 21:45:01 UTC

[GitHub] [airflow] jedcunningham opened a new pull request #19631: Improve `airflow-github` dev script

jedcunningham opened a new pull request #19631:
URL: https://github.com/apache/airflow/pull/19631


   Before:
   ![Screen Shot 2021-11-16 at 2 37 03 PM](https://user-images.githubusercontent.com/66968678/142070146-3898bda2-adb7-45a5-b21b-93747d280be6.png)
   
   After:
   ![Screen Shot 2021-11-16 at 2 41 26 PM](https://user-images.githubusercontent.com/66968678/142070367-c83dab5e-0674-4cef-87b8-58aea2df87c2.png)
   
   These changes lists the type (PR or issue), hides meaningless "merged" for issues, includes a complete url (for quicker navigation to it in the web ui), and adds whitespace around columns while also shrinking them where possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #19631: Improve `airflow-github` dev script

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19631:
URL: https://github.com/apache/airflow/pull/19631#discussion_r751283680



##########
File path: dev/airflow-github
##########
@@ -46,7 +46,7 @@ except ImportError:
     sys.exit(-1)
 
 STATUS_COLOR_MAP = {
-    'Resolved': 'green',
+    'Closed': 'green',
     'Open': 'red',

Review comment:
       I think the idea is to color it in the way that's meaningful for the release manager, not to match GitHub's colors.
   
   Red -> action needed
   Green -> no action needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #19631: Improve `airflow-github` dev script

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #19631:
URL: https://github.com/apache/airflow/pull/19631


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #19631: Improve `airflow-github` dev script

Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19631:
URL: https://github.com/apache/airflow/pull/19631#discussion_r750913310



##########
File path: dev/airflow-github
##########
@@ -46,7 +46,7 @@ except ImportError:
     sys.exit(-1)
 
 STATUS_COLOR_MAP = {
-    'Resolved': 'green',
+    'Closed': 'green',
     'Open': 'red',

Review comment:
       I wonder if it’s a good idea to change the colors because this is now entirely opposite to GitHub’s scheme




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #19631: Improve `airflow-github` dev script

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19631:
URL: https://github.com/apache/airflow/pull/19631#issuecomment-971624075


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org