[jira] [Commented] (TC-99) api/{version}/cdns/:cdn_name/health returns the health of all cdns

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848137#comment-15848137 ] 

ASF GitHub Bot commented on TC-99:
----------------------------------

Github user amiryesh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/240#discussion_r98848532
  
    --- Diff: traffic_ops/app/lib/MojoPlugins/Health.pm ---
    @@ -159,6 +159,9 @@ sub register {
     				cachegroups  => [],
     			};
     
    +			$self->app->log->debug("get_cache_health() - " . 
    --- End diff --
    
    I think that a good practice would be to leave debug messages in the code, and set the default log level, at least in production, to "info", so that debug messages will not clutter production logs.
    
    Since the current log level (defined in log4perl.conf) is "debug" (in all environments) I'd suggest to to change this message's log level from "debug" to "trace". 



> api/{version}/cdns/:cdn_name/health returns the health of all cdns
> ------------------------------------------------------------------
>
>                 Key: TC-99
>                 URL: https://issues.apache.org/jira/browse/TC-99
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Ops API
>            Reporter: Jeremy Mitchell
>            Priority: Minor
>
> There are 2 routes that fetch the health of cachegroups for a cdn:
> (health is defined in this context as the number of offline/online servers for each cachegroup)
> /api/$version/cdns/health
> /api/$version/cdns/:name/health
> ^^ you would think the 2nd one would fetch the health of the cachegroups for the specified cdn but it does not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)