You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/27 16:40:27 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4146: Remove Type from NativeIndex
tustvold opened a new pull request, #4146:
URL: https://github.com/apache/arrow-rs/pull/4146
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Follow up to #3578 that switches `FIXED_LEN_BYTE_ARRAY` to use `FixedLenByteArray` which in turn allows removing `Type` from `NativeIndex`
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #4146: Remove Type from NativeIndex
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #4146:
URL: https://github.com/apache/arrow-rs/pull/4146#discussion_r1179539287
##########
parquet/src/file/page_index/index.rs:
##########
@@ -106,8 +106,6 @@ impl Index {
/// Stores the [`PageIndex`] for each page of a column with [`Type`]
Review Comment:
Do we need to update the doc for the `[Type]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4146: Remove Type from NativeIndex
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4146:
URL: https://github.com/apache/arrow-rs/pull/4146#discussion_r1179445356
##########
parquet/src/file/page_index/index.rs:
##########
@@ -118,11 +116,10 @@ pub struct NativeIndex<T: ParquetValueType> {
}
impl<T: ParquetValueType> NativeIndex<T> {
+ pub const PHYSICAL_TYPE: Type = T::PHYSICAL_TYPE;
Review Comment:
This is necessary because `ParquetValueType` is technically an experimental API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4146: Remove Type from NativeIndex
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4146:
URL: https://github.com/apache/arrow-rs/pull/4146#discussion_r1180108243
##########
parquet/src/file/page_index/index.rs:
##########
@@ -106,8 +106,6 @@ impl Index {
/// Stores the [`PageIndex`] for each page of a column with [`Type`]
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4146: Remove Type from NativeIndex
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4146:
URL: https://github.com/apache/arrow-rs/pull/4146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4146: Remove Type from NativeIndex
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4146:
URL: https://github.com/apache/arrow-rs/pull/4146#discussion_r1179606635
##########
parquet/src/file/page_index/index.rs:
##########
@@ -106,8 +106,6 @@ impl Index {
/// Stores the [`PageIndex`] for each page of a column with [`Type`]
Review Comment:
What did you have in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #4146: Remove Type from NativeIndex
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #4146:
URL: https://github.com/apache/arrow-rs/pull/4146#discussion_r1179690277
##########
parquet/src/file/page_index/index.rs:
##########
@@ -106,8 +106,6 @@ impl Index {
/// Stores the [`PageIndex`] for each page of a column with [`Type`]
Review Comment:
I meant do we need to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org