[GitHub] [superset] junlincc commented on pull request #17505: feat: Move Apply and ClearAll Button below filters and change clearAll Button to link

[GitBox <gi...@apache.org>]

junlincc commented on pull request #17505:
URL: https://github.com/apache/superset/pull/17505#issuecomment-976672650


   Hi @Nithin-George-Philips , first of all, thank you so much for your contribution! 
   As an engineering driven Open Source project, we love to see contribution from individuals and organization. 
   However, certain areas of change in the product are more controversial or sensitive than the others. When it comes to UI/UX changes, larger changes that involved altering user flow and behavior generally require posting a SIP(Superset Improvement Proposal), and getting it voted it before starting implementation. For smaller changes like this PR, we requires PR authors to provide clear rationale of change, detailed context or associate open issue. We are also working on the design guideline that contributor can refer to before making a change. 
   
   In this case, the reason the “Apply” and “Clear all” buttons are on the top is because the list of filters can become very long, in which case the buttons might be outside the currently visible viewport. In addition, keeping them on top makes it possible to keep them sticky when scrolling the filter list.
   
   If you found the current solution is not sufficient for your use case, we suggest you to either kickoff a discussion in the Issue page, or update the PR description with change rational and we can continue our discussion in the thread. 
   
   For now, unfortunately, we will not be able to merge your PR. 
   If you are looking for area to contribute, we are happy to provide a list of UI/UX started issues as well! 
    
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org