You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/09 22:48:24 UTC

[GitHub] [thrift] fishy commented on pull request #2469: THRIFT-5423: Support go parameter validation in IDL

fishy commented on pull request #2469:
URL: https://github.com/apache/thrift/pull/2469#issuecomment-990371184


   > vt.in: must be in specified values
   > vt.not_in: must not be in specified values
   
   it's not clear to me whether that is an enumeration (e.g. `vt.in = "[1, 2, 4, 8]"` or a range (e.g. `vt.in = "[1, 4]"`), and if it's a range, are ends inclusive or exclusive?
   
   I think it would help if you can include the markdown file you attached to the JIRA ticket into this PR so I can review the spec first (and it will be easier to give inline feedback to the spec there), before I review the implementation code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org