You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/22 12:26:49 UTC

[GitHub] yanghua commented on a change in pull request #7153: Hotfix/flink 10918

yanghua commented on a change in pull request #7153: Hotfix/flink 10918
URL: https://github.com/apache/flink/pull/7153#discussion_r235707187
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ##########
 @@ -557,6 +557,16 @@ private void createDB() throws IOException {
 		this.defaultColumnFamily = columnFamilyHandles.get(0);
 	}
 
+	private static class Utils {
+		static String getPathAsString(Path paths) {
 
 Review comment:
   Why named `paths`? I think naming `path` would be better. And this method actually sanitizes for the path. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services