[GitHub] [maven-archetypes] behrangsa commented on a change in pull request #3: Enabled generating Java 9+ projects as well as using JUnit 5.x

[GitBox <gi...@apache.org>]

behrangsa commented on a change in pull request #3: Enabled generating Java 9+ projects as well as using JUnit 5.x
URL: https://github.com/apache/maven-archetypes/pull/3#discussion_r294075370
 
 

 ##########
 File path: maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
 ##########
 @@ -14,17 +47,19 @@
 
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <maven.compiler.source>1.7</maven.compiler.source>
-    <maven.compiler.target>1.7</maven.compiler.target>
+    #if ( ${javaCompilerVersion} == $null )
+      #compilerProperties( "1.7" )
+    #else
+      #compilerProperties( ${javaCompilerVersion} )
+    #end
   </properties>
 
   <dependencies>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>4.11</version>
-      <scope>test</scope>
-    </dependency>
+    #if ( ${junitVersion} == $null )
+      #junit( "4.11" )
 
 Review comment:
   Fixed in 61fd053.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services