You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2022/01/19 14:03:29 UTC
[logging-log4j2] 10/13: Reuse empty array constants.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 01e8c4761ae61e1d3b52564a2433b600a688ba1a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Jan 19 09:00:47 2022 -0500
Reuse empty array constants.
Refactor empty array constants.
---
.../java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java | 3 +--
.../src/test/java/org/apache/logging/slf4j/LoggerContextTest.java | 2 +-
.../src/test/java/org/apache/logging/slf4j/LoggerContextTest.java | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java
index cc2f3ea..73f8f3d 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java
@@ -62,8 +62,7 @@ public class PatternParserTest2 {
final List<PatternConverter> converters = new ArrayList<>();
final List<FormattingInfo> fields = new ArrayList<>();
parser0.parse(pattern, converters, fields, false, false, convert);
- final FormattingInfo[] infoArray = new FormattingInfo[fields.size()];
- final FormattingInfo[] patternFields = fields.toArray(infoArray);
+ final FormattingInfo[] patternFields = fields.toArray(FormattingInfo.EMPTY_ARRAY);
final ArrayPatternConverter[] converterArray = new ArrayPatternConverter[converters.size()];
final ArrayPatternConverter[] patternConverters = converters.toArray(converterArray);
formatFileName(patternConverters, patternFields, buf, date, i);
diff --git a/log4j-slf4j-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java b/log4j-slf4j-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java
index 742fc9b..103e5f8 100644
--- a/log4j-slf4j-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java
+++ b/log4j-slf4j-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java
@@ -35,7 +35,7 @@ public class LoggerContextTest {
Log4jLoggerFactory factory = (Log4jLoggerFactory) StaticLoggerBinder.getSingleton().getLoggerFactory();
factory.getLogger("test");
Set<LoggerContext> set = factory.getLoggerContexts();
- LoggerContext ctx1 = set.toArray(new LoggerContext[0])[0];
+ LoggerContext ctx1 = set.toArray(LoggerContext.EMPTY_ARRAY)[0];
assertTrue("LoggerContext is not enabled for shutdown", ctx1 instanceof LifeCycle);
((LifeCycle) ctx1).stop();
set = factory.getLoggerContexts();
diff --git a/log4j-slf4j18-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java b/log4j-slf4j18-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java
index 3c6403c..de37a36 100644
--- a/log4j-slf4j18-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java
+++ b/log4j-slf4j18-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java
@@ -35,7 +35,7 @@ public class LoggerContextTest {
Log4jLoggerFactory factory = (Log4jLoggerFactory) LoggerFactory.getILoggerFactory();
factory.getLogger("test");
Set<LoggerContext> set = factory.getLoggerContexts();
- LoggerContext ctx1 = set.toArray(new LoggerContext[0])[0];
+ LoggerContext ctx1 = set.toArray(LoggerContext.EMPTY_ARRAY)[0];
assertTrue("LoggerContext is not enabled for shutdown", ctx1 instanceof LifeCycle);
((LifeCycle) ctx1).stop();
set = factory.getLoggerContexts();