You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by GitBox <gi...@apache.org> on 2018/10/06 00:13:45 UTC

[GitHub] rdelval commented on a change in pull request #37: Staggered (Variable batch) Updates

rdelval commented on a change in pull request #37: Staggered (Variable batch) Updates
URL: https://github.com/apache/aurora/pull/37#discussion_r223164022
 
 

 ##########
 File path: src/main/python/apache/aurora/client/api/updater_util.py
 ##########
 @@ -80,6 +84,18 @@ def to_thrift_update_settings(self, instances=None):
     Arguments:
     instances - optional list of instances to update.
     """
+
+    if self.update_strategy is Empty:
 
 Review comment:
   Added a check for these two scenarios as well as tests for them. If you can, please do a sanity check on these.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services