You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by to...@apache.org on 2022/07/31 10:35:44 UTC

[lucene-jira-archive] branch main updated: fix wrong type hint and default value

This is an automated email from the ASF dual-hosted git repository.

tomoko pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene-jira-archive.git


The following commit(s) were added to refs/heads/main by this push:
     new 614a3cd6 fix wrong type hint and default value
614a3cd6 is described below

commit 614a3cd62be8ecf6207e9fb682cd0b376db051fd
Author: Tomoko Uchida <to...@gmail.com>
AuthorDate: Sun Jul 31 19:35:38 2022 +0900

    fix wrong type hint and default value
---
 migration/src/jira_util.py               | 2 +-
 migration/src/remap_cross_issue_links.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/migration/src/jira_util.py b/migration/src/jira_util.py
index e85522d3..83ab00e8 100644
--- a/migration/src/jira_util.py
+++ b/migration/src/jira_util.py
@@ -299,7 +299,7 @@ def convert_text(text: str, att_replace_map: dict[str, str] = {}, account_map: d
     return text
 
 
-def embed_gh_issue_link(text: str, issue_id_map: dict[str, str], gh_number_self: int = None) -> str:
+def embed_gh_issue_link(text: str, issue_id_map: dict[str, int], gh_number_self: int) -> str:
     """Embed GitHub issue number
     """
     def repl_simple(m: re.Match):
diff --git a/migration/src/remap_cross_issue_links.py b/migration/src/remap_cross_issue_links.py
index fd4e563d..18e66ef4 100644
--- a/migration/src/remap_cross_issue_links.py
+++ b/migration/src/remap_cross_issue_links.py
@@ -21,7 +21,7 @@ logger = logging_setup(log_dir, "remap_cross_issue_links")
 
 
 @retry_upto(3, 1.0, logger)
-def remap_issue_link_in_issue_body(issue_number: int, issue_id_map: dict[str, str], data_dir: Path, token: str, repo: str):
+def remap_issue_link_in_issue_body(issue_number: int, issue_id_map: dict[str, int], data_dir: Path, token: str, repo: str):
     body = get_issue_body(token, repo, issue_number, logger)
     if body:
         updated_body = embed_gh_issue_link(body, issue_id_map, issue_number)
@@ -36,7 +36,7 @@ def remap_issue_link_in_issue_body(issue_number: int, issue_id_map: dict[str, st
 
 
 @retry_upto(3, 1.0, logger)
-def remap_issue_link_in_comments(issue_number: int, issue_id_map: dict[str, str], data_dir: Path, token: str, repo: str):
+def remap_issue_link_in_comments(issue_number: int, issue_id_map: dict[str, int], data_dir: Path, token: str, repo: str):
     comments = get_issue_comments(token, repo, issue_number, logger)
     if not comments:
         return