You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/17 16:20:39 UTC

[GitHub] [arrow-datafusion] andygrove commented on pull request #3890: skip failing tests default to false

andygrove commented on PR #3890:
URL: https://github.com/apache/arrow-datafusion/pull/3890#issuecomment-1318880940

   Now that https://github.com/apache/arrow-datafusion/pull/4208 is implemented, I suggest that we:
   
   - Update existing rules to implement `try_optimize` so that they return `Ok(None)` instead of `Err` when the rule does not support the plan (we should create one PR per rule)
   - Change the default value of `datafusion.optimizer.skip_failed_rules` to false, and fix any test failures


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org