You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/27 14:45:43 UTC

[GitHub] [pulsar] Shoothzj opened a new pull request, #15817: [Revert] [#15483] Remove sensitive msg from consumer/producer stats log

Shoothzj opened a new pull request, #15817:
URL: https://github.com/apache/pulsar/pull/15817

   ### Motivation
   See #15483 
   The `@Secret` annotation works well, and introduced in #8910
   
   ### Modifications
   - Revert the unneeded `@JsonIgnore`
   - remove `Assert.assertFalse(s.contains("Password"));` `Password` is printed in a key. The sensitive field's value is `****`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Shoothzj commented on pull request #15817: [Revert] [#15483] Remove sensitive msg from consumer/producer stats log

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15817:
URL: https://github.com/apache/pulsar/pull/15817#issuecomment-1140430682

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Shoothzj merged pull request #15817: [Revert] [#15483] Remove sensitive msg from consumer/producer stats log

Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #15817:
URL: https://github.com/apache/pulsar/pull/15817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Shoothzj commented on pull request #15817: [Revert] [#15483] Remove sensitive msg from consumer/producer stats log

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15817:
URL: https://github.com/apache/pulsar/pull/15817#issuecomment-1143062366

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Shoothzj commented on pull request #15817: [Revert] [#15483] Remove sensitive msg from consumer/producer stats log

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #15817:
URL: https://github.com/apache/pulsar/pull/15817#issuecomment-1141563474

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org