[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

[GitBox <gi...@apache.org>]

ashmeet-kandhari commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1003145131


##########
flink-connectors/flink-connector-kafka/archunit-violations/97dda445-f6bc-43e2-8106-5876ca0cd052:
##########
@@ -26,12 +26,6 @@ org.apache.flink.connector.kafka.source.KafkaSourceITCase does not satisfy: only
 * reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
 * reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\
 * reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
-* reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\
- or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule
-org.apache.flink.connector.kafka.source.KafkaSourceLegacyITCase does not satisfy: only one of the following predicates match:\
-* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
-* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\
-* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\

Review Comment:
   Hi @snuyanzin 
   
   These archunit violations are getting updated automatically after I build the `flink-connector-kafka` module.
   As I have not been interacting with these files, I thought these are expected changes.
   
   Can you please advice me what might be going wrong as the this file gets updated automatically on building the module?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org