You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aitozi (via GitHub)" <gi...@apache.org> on 2023/03/07 12:09:05 UTC
[GitHub] [flink] Aitozi commented on a diff in pull request #22106: [FLINK-30659][hive] Drop flink-sql-parser-hive module
Aitozi commented on code in PR #22106:
URL: https://github.com/apache/flink/pull/22106#discussion_r1127754834
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/validate/FlinkSqlConformance.java:
##########
@@ -60,24 +54,12 @@ public boolean isHavingAlias() {
@Override
public boolean isSortByOrdinal() {
- switch (this) {
- case DEFAULT:
- case HIVE:
- return true;
- default:
- return false;
- }
+ return false;
}
@Override
public boolean isSortByAlias() {
- switch (this) {
- case DEFAULT:
- case HIVE:
- return true;
- default:
- return false;
- }
+ return false;
Review Comment:
this should be true?
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/validate/FlinkSqlConformance.java:
##########
@@ -60,24 +54,12 @@ public boolean isHavingAlias() {
@Override
public boolean isSortByOrdinal() {
- switch (this) {
- case DEFAULT:
- case HIVE:
- return true;
- default:
- return false;
- }
+ return false;
Review Comment:
this should be true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org