[GitHub] [nifi] MikeThomsen opened a new pull request, #6793: NIFI-10990 Added support for converting Record types to JSON strings …

[GitBox <gi...@apache.org>]

MikeThomsen opened a new pull request, #6793:
URL: https://github.com/apache/nifi/pull/6793

   …to DataTypeUtils.
   
   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6793: NIFI-10990 Added support for converting Record types to JSON strings …

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6793:
URL: https://github.com/apache/nifi/pull/6793#discussion_r1051434505


##########
nifi-commons/nifi-record/pom.xml:
##########
@@ -27,4 +27,11 @@
         several interfaces for interacting with Records. This module should not depend
         on any external libraries.
     </description>
+
+    <dependencies>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+        </dependency>
+    </dependencies>

Review Comment:
   As noted in the above module description, the `nifi-record` module should not have any external dependencies.



##########
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java:
##########
@@ -996,6 +999,15 @@ public static String toString(final Object value, final Supplier<DateFormat> for
             }
         }
 
+        if (value instanceof MapRecord) {
+            Map<String, Object> map = ((MapRecord)value).toMap();
+            try {
+                return MAPPER.writerWithDefaultPrettyPrinter().writeValueAsString(map);
+            } catch (Exception ex) {
+                throw new IllegalTypeConversionException("Cannot convert value " + value + " of type " + value.getClass() + " to a valid String", ex);
+            }
+        }

Review Comment:
   This approach forces the implementation into a JSON-specific strategy, which is not necessarily applicable to other record-oriented data formats.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] MikeThomsen closed pull request #6793: NIFI-10990 Added support for converting Record types to JSON strings …

[GitBox <gi...@apache.org>]

MikeThomsen closed pull request #6793: NIFI-10990 Added support for converting Record types to JSON strings …
URL: https://github.com/apache/nifi/pull/6793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org