You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/06 11:43:07 UTC
[PR] fix(desktop): square the ghost answer bubble under paint containment [maka]
Astro-Han opened a new pull request, #4923:
URL: https://github.com/apache/maka/pull/4923
## Summary
The assistant answer bubble is an Astryx ghost `ChatMessageBubble`: no fill, no border, and the 28px `--radius-chat` it inherits paints nothing. #4259 made that bubble a `content-visibility` boundary, and paint containment clips to the rounded padding box, so the invisible corners became clip arcs. In the app (Electron 43.4.1, Chromium 150) the arc shaves the top-left of the first glyph on the first line and the bottom-left of the last line: 环 renders as 不 with a stub, and a list's `3.` loses its 3.
#4906 added `overflow-clip-margin: 2px` against the same symptom. That only pushes the arc out by 2px; in Electron the glyph still loses its corner. The pixel check that passed there ran in Playwright's headless Chromium, where the rounded clip does not reproduce, so Storybook smoke cannot see this either way.
The fix squares the ghost bubble (`border-radius: 0`), which is legal under DESIGN.md's Full-Bleed Rule (`width="100%"`, flush on both sides) and changes no pixel of its own. The 2px margin goes: with the radius gone it makes no measurable difference at 0px or 2px on CJK (环, 第) and Latin (`Jfj PQ`) samples in Electron. DESIGN.md's chat rung row records the exception, and the `WideAssistantProse` play asserts the boundary is square instead of asserting a clip margin.
Fixes #4898
## Verification
Measured in the real app via CDP, Electron 43.4.1 / Chromium 150, session with a multi-block Turn, 4x crops of the first glyph of the second answer:
- main `bd3646b34`: top-left of 环 shaved; `border-radius: 0` alone restores it; `overflow-clip-margin: 8px` also restores it (arc pushed clear), `2px` does not.
- this branch: intact, light and dark; `overflow-clip-margin` 0px vs 2px: identical.
- Playwright Chromium 148 (Storybook) does not reproduce the rounded clip on main, which is why #4906's `pixel_diff=0` held.
- `npm --workspace @maka/desktop run smoke:storybook` — passed (310 stories, 337 theme renders)
- `npm --workspace @maka/desktop run typecheck` — passed
- `npm run format` / `npm run lint` — clean
- Not run: E2E (no Electron main-process or scroll-authority change)
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Claude Code diagnosed the rounded-clip cause with CDP experiments in the running app, wrote the CSS, story and DESIGN.md change, and produced the comparison images under maintainer direction.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): square the ghost answer bubble under paint containment [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4923:
URL: https://github.com/apache/maka/pull/4923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org