You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by WeichenXu123 <gi...@git.apache.org> on 2016/05/21 17:38:50 UTC

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

GitHub user WeichenXu123 opened a pull request:

    https://github.com/apache/spark/pull/13242

    [SPARK-15464][ML][MLlib][SQL][Tests] Replace SQLContext and SparkContext with SparkSession using builder pattern in python test code

    ## What changes were proposed in this pull request?
    
    Replace SQLContext and SparkContext with SparkSession using builder pattern in python test code.
    
    ## How was this patch tested?
    
    Existing test.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WeichenXu123/spark python_doctest_update_sparksession

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13242
    
----
commit e6ff76a5309b4b5d0b23e4eccba413cddab5daa0
Author: WeichenXu <we...@outlook.com>
Date:   2016-05-21T16:09:18Z

    replace SQLContext and SparkContext with SparkSession using builder pattern in python test code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

Posted by rxin <gi...@git.apache.org>.

Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/13242#issuecomment-220812010
  
    cc @andrewor14 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

Posted by WeichenXu123 <gi...@git.apache.org>.

Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13242#discussion_r64147805
  
    --- Diff: python/pyspark/ml/clustering.py ---
    @@ -933,21 +933,20 @@ def getKeepLastCheckpoint(self):
     if __name__ == "__main__":
         import doctest
         import pyspark.ml.clustering
    -    from pyspark.context import SparkContext
    -    from pyspark.sql import SQLContext
    +    from pyspark.sql import SparkSession
         globs = pyspark.ml.clustering.__dict__.copy()
         # The small batch size here ensures that we see multiple batches,
         # even in these small test examples:
    -    sc = SparkContext("local[2]", "ml.clustering tests")
    -    sqlContext = SQLContext(sc)
    +    spark = SparkSession.builder.master("local[2]").appName("ml.clustering tests").getOrCreate()
    --- End diff --
    
    @techaddict Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

Posted by techaddict <gi...@git.apache.org>.

Github user techaddict commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13242#discussion_r64144856
  
    --- Diff: python/pyspark/ml/clustering.py ---
    @@ -933,21 +933,20 @@ def getKeepLastCheckpoint(self):
     if __name__ == "__main__":
         import doctest
         import pyspark.ml.clustering
    -    from pyspark.context import SparkContext
    -    from pyspark.sql import SQLContext
    +    from pyspark.sql import SparkSession
         globs = pyspark.ml.clustering.__dict__.copy()
         # The small batch size here ensures that we see multiple batches,
         # even in these small test examples:
    -    sc = SparkContext("local[2]", "ml.clustering tests")
    -    sqlContext = SQLContext(sc)
    +    spark = SparkSession.builder.master("local[2]").appName("ml.clustering tests").getOrCreate()
    --- End diff --
    
    Can you make this multi line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13242#issuecomment-220792384
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59075/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13242#issuecomment-220791131
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13242#issuecomment-220791132
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59073/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org