You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2022/02/19 01:00:16 UTC
[GitHub] [storm] bipinprasad opened a new pull request #3442: [STORM-3823] Change expected classpath dirs to end with "/*"
bipinprasad opened a new pull request #3442:
URL: https://github.com/apache/storm/pull/3442
## What is the purpose of the change
*While running a release preparation, the test in storm-client/test/py/test_storm_cli.py fails because the directories in classpath have "/*" appended after storm.py runs.*
## How was the change tested
*Rebuild storm using "mvn release:prepare -P dist,rat,externals,examples "*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on a change in pull request #3442: [STORM-3823] Change expected classpath dirs to end with "/*"
Posted by GitBox <gi...@apache.org>.
bipinprasad commented on a change in pull request #3442:
URL: https://github.com/apache/storm/pull/3442#discussion_r812436255
##########
File path: storm-client/test/py/test_storm_cli.py
##########
@@ -93,7 +93,7 @@ def test_localconfvalue_command(self):
self.base_test(
["storm", "localconfvalue", "conf_name"], self.mock_popen, mock.call([
self.java_cmd, '-client', '-Dstorm.options=',
- '-Dstorm.conf.file=', '-cp', self.storm_dir + '/*:' + self.storm_dir + '/lib:' + self.storm_dir +'/extlib:' + self.storm_dir + '/extlib-daemon:' + self.storm_dir + '/conf',
+ '-Dstorm.conf.file=', '-cp', self.storm_dir + '/*:' + self.storm_dir + '/lib/*:' + self.storm_dir +'/extlib:' + self.storm_dir + '/extlib-daemon:' + self.storm_dir + '/conf',
Review comment:
All directories with jars should show in classpath with "/*". I will raise a separate Jira to check if storm.py is doing it and then also fix this test_storm_cli.py.
The test seems to succeed with just this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3442: [STORM-3823] Change expected classpath dirs to end with "/*"
Posted by GitBox <gi...@apache.org>.
bipinprasad merged pull request #3442:
URL: https://github.com/apache/storm/pull/3442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3442: [STORM-3823] Change expected classpath dirs to end with "/*"
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3442:
URL: https://github.com/apache/storm/pull/3442#discussion_r812323912
##########
File path: storm-client/test/py/test_storm_cli.py
##########
@@ -93,7 +93,7 @@ def test_localconfvalue_command(self):
self.base_test(
["storm", "localconfvalue", "conf_name"], self.mock_popen, mock.call([
self.java_cmd, '-client', '-Dstorm.options=',
- '-Dstorm.conf.file=', '-cp', self.storm_dir + '/*:' + self.storm_dir + '/lib:' + self.storm_dir +'/extlib:' + self.storm_dir + '/extlib-daemon:' + self.storm_dir + '/conf',
+ '-Dstorm.conf.file=', '-cp', self.storm_dir + '/*:' + self.storm_dir + '/lib/*:' + self.storm_dir +'/extlib:' + self.storm_dir + '/extlib-daemon:' + self.storm_dir + '/conf',
Review comment:
what determines if a directory needs the * or not? Why not add it to extlib and/or all directories?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org