Re: [PR] OAK-10921 : fixed race condition where fullGC database variables gets… [jackrabbit-oak]

["stefan-egli (via GitHub)" <gi...@apache.org>]

stefan-egli commented on code in PR #1562:
URL: https://github.com/apache/jackrabbit-oak/pull/1562#discussion_r1700399522


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCRecommendations.java:
##########
@@ -345,20 +350,31 @@ private Map<String, Object> getVGCSettings() {
         return settings;
     }
 
-    private void setLongSetting(String propName, long val) {
-        setLongSetting(of(propName, val));
+    private void setVGCSetting(final String propName, final Object val) {
+        setVGCSetting(new HashMap<>() {{

Review Comment:
   Got it. Alternatively, you could of course create the hasmap first, then add the key value. Would be slightly more code but avoid the subclass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org