You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "scsmithr (via GitHub)" <gi...@apache.org> on 2023/04/16 16:07:21 UTC

[GitHub] [arrow-datafusion] scsmithr opened a new pull request, #6028: fix: Add missing arg to execute_and_check

scsmithr opened a new pull request, #6028:
URL: https://github.com/apache/arrow-datafusion/pull/6028

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   N/A
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Pass CI
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Adds missing argument causing check failures.
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   Things compile.
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] scsmithr closed pull request #6028: fix: Add missing arg to execute_and_check

Posted by "scsmithr (via GitHub)" <gi...@apache.org>.
scsmithr closed pull request #6028: fix: Add missing arg to execute_and_check
URL: https://github.com/apache/arrow-datafusion/pull/6028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] scsmithr commented on pull request #6028: fix: Add missing arg to execute_and_check

Posted by "scsmithr (via GitHub)" <gi...@apache.org>.
scsmithr commented on PR #6028:
URL: https://github.com/apache/arrow-datafusion/pull/6028#issuecomment-1510554940

   No worries


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] yjshen commented on pull request #6028: fix: Add missing arg to execute_and_check

Posted by "yjshen (via GitHub)" <gi...@apache.org>.
yjshen commented on PR #6028:
URL: https://github.com/apache/arrow-datafusion/pull/6028#issuecomment-1510547462

   I apologize for overlooking this PR as another one with the same fix was displayed at the top of the list. Thank you for resolving this issue!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org