You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2020/11/17 02:31:00 UTC

[jira] [Updated] (FLINK-17922) Refactor generic and hive table rules for HiveCatalog

     [ https://issues.apache.org/jira/browse/FLINK-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jark Wu updated FLINK-17922:
----------------------------
    Issue Type: Improvement  (was: New Feature)

> Refactor generic and hive table rules for HiveCatalog
> -----------------------------------------------------
>
>                 Key: FLINK-17922
>                 URL: https://issues.apache.org/jira/browse/FLINK-17922
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Hive
>            Reporter: Jingsong Lee
>            Priority: Major
>             Fix For: 1.13.0
>
>
> Now the underlying rules are:
>  * HiveCatalog.createTable , hive table has false of {{isGeneric}} flag, generic table has no flag.
>  * HiveCatalog.getTable , generic table has true of {{isGeneric}} flag, hive table has no flag.
> It is very difficult to understand and easy to cause bugs.
> Whether it's {{createTable}} or {{getTable}} of {{HiveCatalog}}, there should be two types of objects that are consistent: {{HiveCatalogTable}} and Flink {{CatalogTableImpl}}.
> Timo: From a logical perspective, the {{HiveCatalog}} should deal with this additional property while storing and retrieving a {{CatalogTable}}. The {{isGeneric}} should not travel through the stack of regular Flink connector options. It is an internal property from the {{HiveCatalog}} through a custom {{HiveCatalogTable}} to a custom {{HiveFactory}}. It should be stored as a member variable in a {{HiveCatalogTable}}.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)