You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/09 05:59:51 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #11209: perf: add db pagination to speed up uuid column migration
codecov-io commented on pull request #11209:
URL: https://github.com/apache/incubator-superset/pull/11209#issuecomment-705985566
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11209?src=pr&el=h1) Report
> Merging [#11209](https://codecov.io/gh/apache/incubator-superset/pull/11209?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `0.80%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11209/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11209?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11209 +/- ##
==========================================
+ Coverage 61.49% 62.30% +0.80%
==========================================
Files 828 436 -392
Lines 39145 14590 -24555
Branches 3589 3589
==========================================
- Hits 24073 9090 -14983
+ Misses 14892 5320 -9572
Partials 180 180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (ø)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/versions/d39b1e37131d\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kMzliMWUzNzEzMWRfLnB5) | | |
| [...set/migrations/versions/55179c7f25c7\_sqla\_descr.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81NTE3OWM3ZjI1Yzdfc3FsYV9kZXNjci5weQ==) | | |
| [superset/views/chart/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvdmlld3MucHk=) | | |
| [...ions/versions/7e3ddad2a00b\_results\_key\_to\_query.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZTNkZGFkMmEwMGJfcmVzdWx0c19rZXlfdG9fcXVlcnkucHk=) | | |
| [...tions/versions/db527d8c4c78\_add\_db\_verbose\_name.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kYjUyN2Q4YzRjNzhfYWRkX2RiX3ZlcmJvc2VfbmFtZS5weQ==) | | |
| [superset/css\_templates/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9kYW8ucHk=) | | |
| [.../versions/a6c18f869a4e\_query\_start\_running\_time.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hNmMxOGY4NjlhNGVfcXVlcnlfc3RhcnRfcnVubmluZ190aW1lLnB5) | | |
| [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | | |
| [...a74826\_add\_metadata\_column\_to\_annotation\_model\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81NWU5MTBhNzQ4MjZfYWRkX21ldGFkYXRhX2NvbHVtbl90b19hbm5vdGF0aW9uX21vZGVsXy5weQ==) | | |
| [...817e1c9b09d0\_add\_not\_null\_to\_dbs\_sqlalchemy\_url.py](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTdlMWM5YjA5ZDBfYWRkX25vdF9udWxsX3RvX2Ric19zcWxhbGNoZW15X3VybC5weQ==) | | |
| ... and [381 more](https://codecov.io/gh/apache/incubator-superset/pull/11209/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11209?src=pr&el=footer). Last update [761e6db...dcd4c79](https://codecov.io/gh/apache/incubator-superset/pull/11209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org