You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/23 08:05:52 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions

LuciferYang commented on code in PR #37598:
URL: https://github.com/apache/spark/pull/37598#discussion_r952286911


##########
pom.xml:
##########
@@ -2932,7 +2932,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-surefire-plugin</artifactId>
-          <version>3.0.0-M5</version>
+          <version>3.0.0-M7</version>

Review Comment:
   @panbingkun There is a behavioral difference between `3.0.0-M5` and `3.0.0-M7`:
   
   `mvn clean install -pl core -Dtest=none` pass with 3.0.0-M5`, but failed with `3.0.0-M7` as follows:
   
   ```
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project spark-core_2.12: No tests matching pattern "none" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
   ```
   seems that configuration `<failIfNoSpecifiedTests>false</failIfNoSpecifiedTests>` needs to be added
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org