You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/14 20:19:22 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4829: libc: Make perror work without CONFIG_FILE_STREAM

xiaoxiang781216 opened a new pull request #4829:
URL: https://github.com/apache/incubator-nuttx/pull/4829


   ## Summary
   
   ## Impact
   Minor
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4829: libc: Make perror work without CONFIG_FILE_STREAM

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4829:
URL: https://github.com/apache/incubator-nuttx/pull/4829#issuecomment-969095628


   Let, the stdio(implicitly accept stdin/stdout/stderr) API work even the general stdio(fopen, fclose) API doesn't exist. This is the practice already used for printf:
   https://github.com/apache/incubator-nuttx/blob/master/libs/libc/stdio/lib_printf.c#L43-L47
   and relate to make nsh work even without FILE related API:
   https://github.com/apache/incubator-nuttx/pull/4819
   https://github.com/apache/incubator-nuttx-apps/pull/892


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4829: libc: Make perror work without CONFIG_FILE_STREAM

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4829:
URL: https://github.com/apache/incubator-nuttx/pull/4829#issuecomment-972913724


   @davids5 could you merge this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4829: libc: Make perror work without CONFIG_FILE_STREAM

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4829:
URL: https://github.com/apache/incubator-nuttx/pull/4829#issuecomment-970443987


   @davids5 do you have any more concern?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 merged pull request #4829: libc: Make perror work without CONFIG_FILE_STREAM

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #4829:
URL: https://github.com/apache/incubator-nuttx/pull/4829


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org