You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "John Casey (JIRA)" <ji...@codehaus.org> on 2007/02/22 20:39:27 UTC
[jira] Created: (WAGON-72) Wagon.getProtocol() called from
DefaultWagonManager breaks when used with wagon-webdav 1.0-beta-2
Wagon.getProtocol() called from DefaultWagonManager breaks when used with wagon-webdav 1.0-beta-2
-------------------------------------------------------------------------------------------------
Key: WAGON-72
URL: http://jira.codehaus.org/browse/WAGON-72
Project: wagon
Issue Type: Bug
Affects Versions: 1.0
Environment: Maven 2.1-SNAPSHOT (revId: 508621); wagon 1.0-beta-3-SNAPSHOT (revId: 509353)
Reporter: John Casey
Priority: Blocker
Attachments: output.log, wagon-webdav-extension.zip
The newest snapshot of 1.0-beta-3 of the wagon-manager has DefaultWagonManager (line 414) calling Wagon.getProtocol(), which doesn't exist in the API until February 8th, 2007 (after -beta-1 and -beta-2 have been released). This means we cannot use released wagons with this manager.
The fix is easy, but we need to put into place infrastructure for integration testing. I'm attaching a project that expresses this problem. Also, I'm attaching the output from `mvn clean` on this project.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (WAGON-72) Wagon.getProtocol() called from
DefaultWagonManager breaks when used with wagon-webdav 1.0-beta-2
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed WAGON-72.
---------------------------
Assignee: John Casey
Resolution: Fixed
Fix Version/s: 1.0
I revised the wagon-provider-api, with the help of clirr. For any method added in to the Wagon interface in the new snapshot, I added a default implementation that returned null in AbstractWagon. I also returned openConnection() to public (it had been revised to protected in -beta-2 -> -beta-3-snap).
Finally, I reinstated the old constructors for the events, and marked them deprecated...I also marked all of the above changes deprecated, except for the default impls of new methods.
These changes, along with a defensive Repository-instance copy in the DefaultWagonManager prior to calling setRepository(..) on the Wagon, should fix backward compat (at least as far back as -beta-2, I haven't checked -beta-1 yet).
> Wagon.getProtocol() called from DefaultWagonManager breaks when used with wagon-webdav 1.0-beta-2
> -------------------------------------------------------------------------------------------------
>
> Key: WAGON-72
> URL: http://jira.codehaus.org/browse/WAGON-72
> Project: wagon
> Issue Type: Bug
> Affects Versions: 1.0
> Environment: Maven 2.1-SNAPSHOT (revId: 508621); wagon 1.0-beta-3-SNAPSHOT (revId: 509353)
> Reporter: John Casey
> Assigned To: John Casey
> Priority: Blocker
> Fix For: 1.0
>
> Attachments: output.log, wagon-webdav-extension.zip
>
>
> The newest snapshot of 1.0-beta-3 of the wagon-manager has DefaultWagonManager (line 414) calling Wagon.getProtocol(), which doesn't exist in the API until February 8th, 2007 (after -beta-1 and -beta-2 have been released). This means we cannot use released wagons with this manager.
> The fix is easy, but we need to put into place infrastructure for integration testing. I'm attaching a project that expresses this problem. Also, I'm attaching the output from `mvn clean` on this project.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira