[GitHub] [apisix] moonming commented on pull request #3883: feat: add 5xx error page

[GitBox <gi...@apache.org>]

moonming commented on pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#issuecomment-811635388


   Of course, we need the 4xx page.
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   Peter Zhu ***@***.***> 于2021年4月1日周四 下午12:45写道：
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In apisix/cli/ngx_tpl.lua
   > <https://github.com/apache/apisix/pull/3883#discussion_r605372197>:
   >
   > > @@ -233,6 +233,9 @@ http {
   >      {% end %}
   >      {% end %}
   >
   > +    # error_page
   > +    error_page 500 502 503 504 @apisix_error_handler;
   >
   > Now the 4xx situation like:
   >
   > 404: {"error_msg":"404 Route Not Found"}
   > 401: {"code":4107,"message":"request
   > unauthorized","data":null,"request_id":""}
   >
   > We will return JSON, do this need to add an error page?
   > IMO, it doesn't need now.
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix/pull/3883#discussion_r605372197>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBK23EDVVWLBE5EIVAJLTGP26BANCNFSM4ZUF3MSA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org