You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/23 21:00:13 UTC

[GitHub] [solr] dsmiley commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

dsmiley commented on PR #1039:
URL: https://github.com/apache/solr/pull/1039#issuecomment-1256674360

   Thanks for this.
   It'd help reviewing if you did the work in separate commits.  That way I could look at the commits and maybe review some commits of interest to me.
   For example inlining deprecated methods on SolrException could have been its own commit.  This in particular feels different in nature from the other changes that it should be in some other PR, actually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org