[jira] [Updated] (MAPREDUCE-6286) A typo in HistoryViewer makes some code useless.

["zhihai xu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhihai xu updated MAPREDUCE-6286:
---------------------------------
    Status: Patch Available  (was: Open)

> A typo in HistoryViewer makes some code useless.
> ------------------------------------------------
>
>                 Key: MAPREDUCE-6286
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6286
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: MAPREDUCE-6286.000.patch
>
>
> A typo in HistoryViewer makes some code useless.
> The typo is
> Limits.reset(conf);
> We should use jobConf instead of conf.
> With the typo, the following code becomes useless:
> {code}
>       final Path jobConfPath = new Path(jobFile.getParent(),  jobDetails[0]
>           + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
>       final Configuration jobConf = new Configuration(conf);
>         jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
> {code}
> The code wants to load the configuration from the Job configuration file and reset the Limits based on the new configuration loaded from the Job configuration file.
> So this typo is apparent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)