You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2017/09/24 16:51:02 UTC

[jira] [Comment Edited] (GUACAMOLE-390) improve UX in github PR

    [ https://issues.apache.org/jira/browse/GUACAMOLE-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178275#comment-16178275 ] 

Michael Jumper edited comment on GUACAMOLE-390 at 9/24/17 4:50 PM:
-------------------------------------------------------------------

As we have a {{CONTRIBUTING}} file in all repositories, GitHub does already show a message prior to opening a PR:

!github-pr-message.png|width=100%!

How will this improve things further? As it's clear that users often ignore the existing message when opening pull requests for the first time, what is less easy to ignore in this case?

*EDIT:* Copied over to the PR on GitHub, as that will likely be a better place to discuss since the PR for this is open already: https://github.com/apache/incubator-guacamole-server/pull/111#issuecomment-331722882


was (Author: mike.jumper):
As we have a {{CONTRIBUTING}} file in all repositories, GitHub does already show a message prior to opening a PR:

!github-pr-message.png|width=100%!

How will this improve things further? As it's clear that users often ignore the existing message when opening pull requests for the first time, what is less easy to ignore in this case?

> improve UX in github PR
> -----------------------
>
>                 Key: GUACAMOLE-390
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-390
>             Project: Guacamole
>          Issue Type: Improvement
>            Reporter: Ilya Shipitsin
>            Priority: Trivial
>         Attachments: github-pr-message.png
>
>
> github can show some message when PR is open, no need to spend reviewers time on those things



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)