You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "edumuellerFSL (via GitHub)" <gi...@apache.org> on 2024/01/20 12:51:42 UTC
[PR] Add dataset create endpoint [airflow]
edumuellerFSL opened a new pull request, #36929:
URL: https://github.com/apache/airflow/pull/36929
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR adds a new feature to create datasets via the API, enhancing the data management capabilities of Airflow. The feature includes a new POST endpoint for dataset creation with necessary tests and API specification updates. This addition enriches the Airflow API by allowing programmatic dataset management, providing users with more flexibility and automation options in their workflows.
related: #36686
discussion: https://github.com/apache/airflow/discussions/36723
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dataset create endpoint [airflow]
Posted by "edumuellerFSL (via GitHub)" <gi...@apache.org>.
edumuellerFSL commented on PR #36929:
URL: https://github.com/apache/airflow/pull/36929#issuecomment-1911623991
> I think this one should hold before we conclude https://lists.apache.org/thread/q4sd09xymvlskxdgcb1s6gfsqwnvqs2o discussion (so I am doing "Request changes" unti it does - and end up with a VOTE or CONSENSUS).
>
>
>
> Whether to create/delete datasets externally is a decision that should be made deliberately, and there are various voices there - some (including myself) think that dataset management should be done internally by Airflow (including possibly reference counting and automatically removing datasets that are not referred by any DAGS) while some others think that there is a value in managing datasets from outside. Until that discussion concludes, I think we should hold on with merging this change.
I agree, that's why I converted it into a Draft. Thanks @potiuk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dataset create endpoint [airflow]
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR commented on PR #36929:
URL: https://github.com/apache/airflow/pull/36929#issuecomment-1905184858
This wouldn't provide any functionality until there's a way to update a dataset via API, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dataset create endpoint [airflow]
Posted by "edumuellerFSL (via GitHub)" <gi...@apache.org>.
edumuellerFSL commented on PR #36929:
URL: https://github.com/apache/airflow/pull/36929#issuecomment-1905854281
> This wouldn't provide any functionality until there's a way to update a dataset via API, right?
Hi @RNHTTR that's right, let me convert this to a draft for the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dataset create endpoint [airflow]
Posted by "edumuellerFSL (via GitHub)" <gi...@apache.org>.
edumuellerFSL closed pull request #36929: Add dataset create endpoint
URL: https://github.com/apache/airflow/pull/36929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dataset create endpoint [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #36929:
URL: https://github.com/apache/airflow/pull/36929#issuecomment-1902086646
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dataset create endpoint [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #36929:
URL: https://github.com/apache/airflow/pull/36929#issuecomment-1909461691
Is this useful in any case? A dataset is created in the database when a DAG listens to it (via `schedule=[dataset]`). A dataset created from API is useless because triggering an event of it would do nothing. To make it possible to trigger an event-driven DAG, we need an API to create DatasetEvent entries, not datasets themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org