You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sk0x50 (via GitHub)" <gi...@apache.org> on 2026/01/23 15:47:17 UTC
[PR] IGNITE-27646 Fix ItRebalanceMetricsTest.testRebalanceMetrics [ignite-3]
sk0x50 opened a new pull request, #7472:
URL: https://github.com/apache/ignite-3/pull/7472
https://issues.apache.org/jira/browse/IGNITE-27646
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27646 Fix ItRebalanceMetricsTest.testRebalanceMetrics [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #7472:
URL: https://github.com/apache/ignite-3/pull/7472#discussion_r2758664830
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceMetricsTest.java:
##########
@@ -124,48 +88,44 @@ void testRebalanceMetrics() throws Exception {
assertRebalanceMetrics(node0, ZONE_NAME, 0, 0);
- CountDownLatch latch = new CountDownLatch(1);
- AtomicBoolean skipEventProcessing = new AtomicBoolean(false);
- String pendingAssignmentsKey = ZoneRebalanceUtil.PENDING_ASSIGNMENTS_QUEUE_PREFIX + zoneId + "_part_";
- ByteArray pendingAssignmentsBytes = new ByteArray(pendingAssignmentsKey);
-
- WatchListener listener = new PendingAssignmentsWatchListener(pendingAssignmentsKey, latch, skipEventProcessing);
-
// Start a new node and register a watch listener for pending assignments.
IgniteImpl node1 = unwrapIgniteImpl(startNode(1));
- node0.metaStorageManager().registerPrefixWatch(pendingAssignmentsBytes, listener);
- node1.metaStorageManager().registerPrefixWatch(pendingAssignmentsBytes, listener);
+ // Task to block a single threaded rebalance pool.
+ CountDownLatch rebalanceLatch = new CountDownLatch(1);
+ Runnable poisonPill = () -> {
Review Comment:
Hi @alievmirza ,
Please take a look at the updated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27646 Fix ItRebalanceMetricsTest.testRebalanceMetrics [ignite-3]
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #7472:
URL: https://github.com/apache/ignite-3/pull/7472#discussion_r2731083764
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceMetricsTest.java:
##########
@@ -124,48 +88,44 @@ void testRebalanceMetrics() throws Exception {
assertRebalanceMetrics(node0, ZONE_NAME, 0, 0);
- CountDownLatch latch = new CountDownLatch(1);
- AtomicBoolean skipEventProcessing = new AtomicBoolean(false);
- String pendingAssignmentsKey = ZoneRebalanceUtil.PENDING_ASSIGNMENTS_QUEUE_PREFIX + zoneId + "_part_";
- ByteArray pendingAssignmentsBytes = new ByteArray(pendingAssignmentsKey);
-
- WatchListener listener = new PendingAssignmentsWatchListener(pendingAssignmentsKey, latch, skipEventProcessing);
-
// Start a new node and register a watch listener for pending assignments.
IgniteImpl node1 = unwrapIgniteImpl(startNode(1));
- node0.metaStorageManager().registerPrefixWatch(pendingAssignmentsBytes, listener);
- node1.metaStorageManager().registerPrefixWatch(pendingAssignmentsBytes, listener);
+ // Task to block a single threaded rebalance pool.
+ CountDownLatch rebalanceLatch = new CountDownLatch(1);
+ Runnable poisonPill = () -> {
Review Comment:
let's use something like `org.apache.ignite.internal.disaster.ItDisasterRecoveryReconfigurationTest#blockRebalanceStableSwitch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27646 Fix ItRebalanceMetricsTest.testRebalanceMetrics [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #7472:
URL: https://github.com/apache/ignite-3/pull/7472#discussion_r2758947505
##########
modules/transactions/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryManagerTest.java:
##########
@@ -647,8 +646,11 @@ private void blockStableSwitch(
ZonePartitionId replicationGroupId = new ZonePartitionId(zoneId(node.catalogManager(), testZone), 0);
- blockMessage(cluster, (nodeName, msg) ->
- blocked.get() && stableKeySwitchMessage(msg, replicationGroupId, assignmentsPending, reached)
+ blockStableKeySwitch(
Review Comment:
Nice catch! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27646 Fix ItRebalanceMetricsTest.testRebalanceMetrics [ignite-3]
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #7472:
URL: https://github.com/apache/ignite-3/pull/7472#discussion_r2758908980
##########
modules/transactions/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryManagerTest.java:
##########
@@ -647,8 +646,11 @@ private void blockStableSwitch(
ZonePartitionId replicationGroupId = new ZonePartitionId(zoneId(node.catalogManager(), testZone), 0);
- blockMessage(cluster, (nodeName, msg) ->
- blocked.get() && stableKeySwitchMessage(msg, replicationGroupId, assignmentsPending, reached)
+ blockStableKeySwitch(
Review Comment:
we have lost `reached` flag here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27646 Fix ItRebalanceMetricsTest.testRebalanceMetrics [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #7472:
URL: https://github.com/apache/ignite-3/pull/7472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org