You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/28 06:36:59 UTC
[GitHub] [superset] villebro commented on a diff in pull request #21958: chore: bump pyathena and related packages
villebro commented on code in PR #21958:
URL: https://github.com/apache/superset/pull/21958#discussion_r1007695303
##########
setup.py:
##########
@@ -120,11 +120,11 @@ def get_git_sha() -> str:
"sqlparse>=0.4.3, <0.5",
"tabulate>=0.8.9, <0.9",
# needed to support Literal (3.8) and TypeGuard (3.10)
- "typing-extensions>=3.10, <4",
+ "typing-extensions>=4, <5",
Review Comment:
Can we add a comment to the description that `typing-extensions` is also bumped in this PR? Also, can you remove the reference to `Literal` on line 122, as we're no longer supporting Python 3.7 or lower (in other words, we currently only need `TypeGuard` from `typing-extensions`)
##########
requirements/base.txt:
##########
@@ -232,16 +231,14 @@ six==1.16.0
# bleach
# click-repl
# flask-talisman
- # holidays
# isodate
# jsonschema
# polyline
# prison
# pyrsistent
# python-dateutil
- # sqlalchemy-utils
# wtforms-json
-slack_sdk==3.18.3
Review Comment:
Good catch. Rant: I always cringe at the fact that `-` and `_` can be used interchangeably for Python deps.. 😡
##########
setup.py:
##########
@@ -120,11 +120,11 @@ def get_git_sha() -> str:
"sqlparse>=0.4.3, <0.5",
"tabulate>=0.8.9, <0.9",
# needed to support Literal (3.8) and TypeGuard (3.10)
- "typing-extensions>=3.10, <4",
+ "typing-extensions>=4, <5",
Review Comment:
Can we add a comment to the PR description that `typing-extensions` is also bumped in this PR? Also, can you remove the reference to `Literal` on line 122, as we're no longer supporting Python 3.7 or lower (in other words, we currently only need `TypeGuard` from `typing-extensions`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org