[GitHub] [kafka] mimaison commented on a change in pull request #11394: KAFKA-13284: Use sftp to upload artifacts in release.py

[GitBox <gi...@apache.org>]

mimaison commented on a change in pull request #11394:
URL: https://github.com/apache/kafka/pull/11394#discussion_r728264561



##########
File path: release.py
##########
@@ -207,10 +217,10 @@ def get_jdk(prefs, version):
     jdk_java_home = get_pref(prefs, 'jdk%d' % version, lambda: raw_input("Enter the path for JAVA_HOME for a JDK%d compiler (blank to use default JAVA_HOME): " % version))
     jdk_env = dict(os.environ) if jdk_java_home.strip() else None
     if jdk_env is not None: jdk_env['JAVA_HOME'] = jdk_java_home
-    javaVersion = cmd_output("%s/bin/java -version" % jdk_java_home, env=jdk_env)
-    if version == 8 and "1.8.0" not in javaVersion:
+    java_version = cmd_output("%s/bin/java -version" % jdk_java_home, env=jdk_env)
+    if version == 8 and "1.8.0" not in java_version:
       fail("JDK 8 is required")
-    elif "%d.0" % version not in javaVersion:
+    elif "%d" % version not in java_version:

Review comment:
       OpenJDK 17 version:
   ```
   openjdk version "17" 2021-09-14
   OpenJDK Runtime Environment Temurin-17+35 (build 17+35)
   OpenJDK 64-Bit Server VM Temurin-17+35 (build 17+35, mixed mode, sharing)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org