You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/12 07:21:22 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4471: Packaging: new timestamp format and add output dir option
ustcweizhou opened a new pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471
### Description
This PR add an option "-o" to specify the output directory of packages.
Usage:
cd packaging && ./build-deb.sh -T -o ~/packages/$BRANCH_NAME
This PR also changes the format of timestamp when create packages using "./build-deb.sh -T"
old output
```
# ls -l *16052*
-rw-r--r-- 1 jenkins jenkins 12509 Nov 12 22:31 cloudstack_4.14.1.0-1605219288~bionic_amd64.buildinfo
-rw-r--r-- 1 jenkins jenkins 3714 Nov 12 22:31 cloudstack_4.14.1.0-1605219288~bionic_amd64.changes
-rw-r--r-- 1 jenkins jenkins 62306764 Nov 12 22:30 cloudstack-agent_4.14.1.0-1605219288~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 61913896 Nov 12 22:30 cloudstack-common_4.14.1.0-1605219288~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 52964 Nov 12 22:30 cloudstack-docs_4.14.1.0-1605219288~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 651156 Nov 12 22:30 cloudstack-integration-tests_4.14.1.0-1605219288~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 107535424 Nov 12 22:31 cloudstack-management_4.14.1.0-1605219288~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 508912 Nov 12 22:30 cloudstack-marvin_4.14.1.0-1605219288~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 48869360 Nov 12 22:31 cloudstack-usage_4.14.1.0-1605219288~bionic_all.deb
```
new output
```
# ls -l
total 277092
-rw-rw-r-- 1 jenkins jenkins 12619 Nov 12 09:25 cloudstack_4.14.1.0-20201112T085715~bionic_amd64.buildinfo
-rw-rw-r-- 1 jenkins jenkins 3849 Nov 12 09:25 cloudstack_4.14.1.0-20201112T085715~bionic_amd64.changes
-rw-r--r-- 1 jenkins jenkins 62132640 Nov 12 09:24 cloudstack-agent_4.14.1.0-20201112T085715~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 62454532 Nov 12 09:24 cloudstack-common_4.14.1.0-20201112T085715~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 52964 Nov 12 09:24 cloudstack-docs_4.14.1.0-20201112T085715~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 662468 Nov 12 09:24 cloudstack-integration-tests_4.14.1.0-20201112T085715~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 107355880 Nov 12 09:25 cloudstack-management_4.14.1.0-20201112T085715~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 512556 Nov 12 09:24 cloudstack-marvin_4.14.1.0-20201112T085715~bionic_all.deb
-rw-r--r-- 1 jenkins jenkins 50534436 Nov 12 09:25 cloudstack-usage_4.14.1.0-20201112T085715~bionic_all.deb
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-781247744
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-778026455
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-780337349
Last packaging failed on centos7 due to backend issue re-running
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-781274971
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-780356376
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-732075533
> LGTM. Packages created with the new timestamp and moved to the output directory
> However it would be nice to echo that the packages can be found in $OUTPUT_DIR since in the logs it mentions that the packages are being built in the current directory
>
> ```
> dpkg-deb: building package 'cloudstack-common' in '../cloudstack-common_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
> dpkg-deb: building package 'cloudstack-docs' in '../cloudstack-docs_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
> dpkg-deb: building package 'cloudstack-integration-tests' in '../cloudstack-integration-tests_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
> dpkg-deb: building package 'cloudstack-marvin' in '../cloudstack-marvin_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
> dpkg-deb: building package 'cloudstack-usage' in '../cloudstack-usage_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
> dpkg-deb: building package 'cloudstack-agent' in '../cloudstack-agent_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
> dpkg-deb: building package 'cloudstack-management' in '../cloudstack-management_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
> ```
@davidjumani good. I will add the message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-778026035
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-732987249
@PaulAngus @rhtyd in spite of not being a bug fix, i think we can take this in before release, do you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-781247052
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-780337685
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471#issuecomment-778044168
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4471: Packaging: new timestamp format and add output dir option
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4471:
URL: https://github.com/apache/cloudstack/pull/4471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org