[GitHub] williaster commented on issue #4981: Make time filter more usable

[GitBox <gi...@apache.org>]

williaster commented on issue #4981: Make time filter more usable
URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391074382
 
 
   There's some great improvements here! My thoughts on other issues being discussed
   
   - ++ tabs, we should try hard to move to a world of visual consistency. 
   - ++ using the condensed padding that @GabeLoins mentioned, again visual consistency and we purposefully used condensed tabs for his work on metrics/filters.
   - I think using Ok/cancel is also a good idea, that's a pretty common web paradigm 
   - I think "Range" and "Start/End" are confusing, they are both ranges in the end right? I'm not sure of the best language here, it seems like "range" is really just smart defaults for choosing the start date? will continue to think on this
   - I like having both the radio buttons + dropdown in the same window pane, IMO it doesn't seem useful to have the radio buttons stand on their own.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org