You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2003/05/05 23:57:50 UTC

Re: svn commit: rev 5816 - in trunk/subversion: libsvn_client libsvn_wc

On Monday, May 5, 2003, at 07:24 PM, rooneg@tigris.org wrote:

> Author: rooneg
> Date: Mon May  5 18:24:18 2003
> New Revision: 5816
>
> Modified:
>    trunk/subversion/libsvn_client/cat.c
>    trunk/subversion/libsvn_wc/translate.c
> Log:
> Fix the warnings that snuck in with revisions 5800 and 5801.

Apparently I managed to get a Makefile with no -W's in my CFLAGS 
(configured without --enable-maintainer-mode I guess).  Actually, now 
that I've reconfigured with --enable-maintainer-mode, it got me 
-Wpointer-arith, -Wwrite-strings, and -Wshadow, but that's it.  Still 
doesn't seem to be producing warnings for unused variables, which is 
annoying.  I've added in -Wall and -Werror manually, just in case, but 
didn't we used to have more warnings turned on if we detected that we 
were compiling under GCC?

-garrett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 5816 - in trunk/subversion: libsvn_client libsvn_wc

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Tuesday, May 6, 2003, at 12:01 PM, kfogel@collab.net wrote:

> Yes, I thought we did too.  My Makefile is always produced by:
>
>    ./configure --enable-maintainer-mode           \
>                --with-apr=/usr/local/apache2      \
>                --with-aprutil=/usr/local/apache2
>
> and it contains
>
>    CFLAGS = -g -Wall -Wmissing-prototypes -Wstrict-prototypes    \
>             -Wmissing-declarations -pthread -DNEON_ZLIB -std=c89 \
>             -Wpointer-arith -Wwrite-strings -Wshadow -DSVN_DEBUG \
>             -DAP_DEBUG  $(EXTRA_CFLAGS)
>
> :-(  I have no idea why your Makefile's CFLAGS are different.

i think i figured it out.  our CFLAGS includes APR's CFLAGS, and the 
version of APR i'm linking against was not configured with 
--enable-maintainer-mode, and that seems to be where those extra 
warning flags come from.

-garrett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 5816 - in trunk/subversion: libsvn_client libsvn_wc

Posted by kf...@collab.net.
Garrett Rooney <ro...@electricjellyfish.net> writes:
> Apparently I managed to get a Makefile with no -W's in my CFLAGS
> (configured without --enable-maintainer-mode I guess).  Actually, now
> that I've reconfigured with --enable-maintainer-mode, it got me
> -Wpointer-arith, -Wwrite-strings, and -Wshadow, but that's it.  Still
> doesn't seem to be producing warnings for unused variables, which is
> annoying.  I've added in -Wall and -Werror manually, just in case, but
> didn't we used to have more warnings turned on if we detected that we
> were compiling under GCC?

Yes, I thought we did too.  My Makefile is always produced by:

   ./configure --enable-maintainer-mode           \
               --with-apr=/usr/local/apache2      \
               --with-aprutil=/usr/local/apache2

and it contains

   CFLAGS = -g -Wall -Wmissing-prototypes -Wstrict-prototypes    \
            -Wmissing-declarations -pthread -DNEON_ZLIB -std=c89 \
            -Wpointer-arith -Wwrite-strings -Wshadow -DSVN_DEBUG \
            -DAP_DEBUG  $(EXTRA_CFLAGS)

:-(  I have no idea why your Makefile's CFLAGS are different.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org