You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Claude Brisson (JIRA)" <ve...@apache.org> on 2006/11/28 16:11:23 UTC

[jira] Created: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

skip jar verification by default and add force.jar.loading
----------------------------------------------------------

                 Key: VELTOOLS-72
                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
             Project: VelocityTools
          Issue Type: Improvement
          Components: Build
    Affects Versions: 1.3
         Environment: all
            Reporter: Claude Brisson
            Priority: Minor
         Attachments: tools-jar-downloading.patch

Same patch as for the engine. Three modes, as summarized Wil:

-- normal - only download jars if missing

-- skip.jar.download - never download jars

-- force.jar.download -- always download jars

And timestamp is not anymore checked since filenames contain version numbers.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Reopened: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Henning Schmiedehausen (JIRA)" <ve...@apache.org>.
     [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=all ]

Henning Schmiedehausen reopened VELTOOLS-72:
--------------------------------------------

             

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Resolved: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Claude Brisson (JIRA)" <de...@velocity.apache.org>.
     [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claude Brisson resolved VELTOOLS-72.
------------------------------------

    Resolution: Fixed

skip.jar.loading and force.jar.loading behaviour is now consistent, same behaviour as for the engine

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: Velocity Tools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Commented: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Henning Schmiedehausen (JIRA)" <ve...@apache.org>.
    [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=comments#action_12454105 ] 
            
Henning Schmiedehausen commented on VELTOOLS-72:
------------------------------------------------

Hm. You already applied that patch. In true "commit-then-review" style, I'd like to -1 that patch until further discussion. Please see VELOCITY-502 for that.

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Updated: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Claude Brisson (JIRA)" <ve...@apache.org>.
     [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=all ]

Claude Brisson updated VELTOOLS-72:
-----------------------------------

    Attachment: tools-jar-downloading.patch

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Commented: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Henning Schmiedehausen (JIRA)" <ve...@apache.org>.
    [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=comments#action_12454104 ] 
            
Henning Schmiedehausen commented on VELTOOLS-72:
------------------------------------------------

Can we please track this in only one issue? VELOCITY-502 or VELTOOLS-72?

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Commented: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Henning Schmiedehausen (JIRA)" <ve...@apache.org>.
    [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=comments#action_12454125 ] 
            
Henning Schmiedehausen commented on VELTOOLS-72:
------------------------------------------------

Sorry, didn't mean to be harsh. Yes, I meant, that we do "if you consider the patch good, commit it, peer review is afterwards". Geronimo did "review-then-commit" for a while and IIRC, httpd is doing so, too.

No offense meant. :-)

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Commented: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
    [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=comments#action_12454114 ] 
            
Nathan Bubna commented on VELTOOLS-72:
--------------------------------------

hey now, let's not make rash assumptions.  i *did* review and test the patch before committing it.  it certainly could be improved, and i'm interested in Will's suggested improvements, but i don't do commit-then-review.  thanks.

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Commented: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
    [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=comments#action_12454119 ] 
            
Nathan Bubna commented on VELTOOLS-72:
--------------------------------------

heh.  i just realized i made myself a hypocrite by rashly assuming you meant the "commit-then-review" comment to say i hadn't reviewed it, when you probably meant "peer review", not personal review.  d'oh.  sorry.

let's call it "commit-then-discuss" in order to clarify that this involves multiple committers. :)

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Resolved: (VELTOOLS-72) skip jar verification by default and add force.jar.loading

Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
     [ http://issues.apache.org/jira/browse/VELTOOLS-72?page=all ]

Nathan Bubna resolved VELTOOLS-72.
----------------------------------

    Fix Version/s: 1.3
       Resolution: Fixed

Thanks, Claude!

> skip jar verification by default and add force.jar.loading
> ----------------------------------------------------------
>
>                 Key: VELTOOLS-72
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-72
>             Project: VelocityTools
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.3
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: tools-jar-downloading.patch
>
>
> Same patch as for the engine. Three modes, as summarized Wil:
> -- normal - only download jars if missing
> -- skip.jar.download - never download jars
> -- force.jar.download -- always download jars
> And timestamp is not anymore checked since filenames contain version numbers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org