You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "scwlkq (via GitHub)" <gi...@apache.org> on 2024/01/28 16:07:04 UTC
[PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
scwlkq opened a new pull request, #4759:
URL: https://github.com/apache/eventmesh/pull/4759
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #1013
### Motivation
Java sdk split multiple sdk by communication protocol
### Modifications
1. I found that the EventMeshCommon class in the original TCP package was referenced by the classes of grpc, HTTP, and other modules, so I placed this class under the Common module and corrected the reference.This also eliminates the coupling between the modules of the Java SDK.
2. I will split the original SDKs.
However, the Catalog requires the use of the selector and GRPC modules, so they are placed together. The same applies to the WorkFlow module and selector module.
*I am not sure if this segmentation method is correct. If there are any shortcomings, please let me kown, and i will correct it.*
### Documentation
- Does this pull request introduce a new feature? ( no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "scwlkq (via GitHub)" <gi...@apache.org>.
scwlkq closed pull request #4759: [ISSUE 1013] Java sdk split multiple sdk by communication protocol
URL: https://github.com/apache/eventmesh/pull/4759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1916243153
My personal opinion is to divide them according to different languages, such as Rust, Java, and Go. Instead of dividing them for each protocol, dividing them too finely will lead to a very bloated project. At the same time, whether other language SDKs should also be divided in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1914453155
>too much sdks for users, doesn't it?
makes sense.
cc @xwm1992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1913652570
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `173 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`378aa75`)](https://app.codecov.io/gh/apache/eventmesh/commit/378aa7597f037801b75699c45b946fcb27c14c46?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.62% compared to head [(`5cdc582`)](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.65%.
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...sh/client/grpc/consumer/EventMeshGrpcConsumer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvY29uc3VtZXIvRXZlbnRNZXNoR3JwY0NvbnN1bWVyLmphdmE=) | 61.78% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...entmesh/client/grpc/consumer/SubStreamHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvY29uc3VtZXIvU3ViU3RyZWFtSGFuZGxlci5qYXZh) | 57.97% | [24 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...h/client/grpc/util/EventMeshCloudEventBuilder.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbG91ZEV2ZW50QnVpbGRlci5qYXZh) | 79.38% | [17 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sh/client/grpc/producer/EventMeshGrpcProducer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvcHJvZHVjZXIvRXZlbnRNZXNoR3JwY1Byb2R1Y2VyLmphdmE=) | 54.05% | [13 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...tmesh/client/grpc/producer/CloudEventProducer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvcHJvZHVjZXIvQ2xvdWRFdmVudFByb2R1Y2VyLmphdmE=) | 66.66% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...client/grpc/producer/EventMeshMessageProducer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvcHJvZHVjZXIvRXZlbnRNZXNoTWVzc2FnZVByb2R1Y2VyLmphdmE=) | 74.41% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...nt/grpc/exception/ProtocolNotSupportException.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvZXhjZXB0aW9uL1Byb3RvY29sTm90U3VwcG9ydEV4Y2VwdGlvbi5qYXZh) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../client/grpc/config/EventMeshGrpcClientConfig.java](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL2V2ZW50bWVzaC1ncnBjLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvY29uZmlnL0V2ZW50TWVzaEdycGNDbGllbnRDb25maWcuamF2YQ==) | 66.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4759 +/- ##
============================================
+ Coverage 17.62% 17.65% +0.03%
+ Complexity 1784 1783 -1
============================================
Files 805 798 -7
Lines 29924 29833 -91
Branches 2580 2575 -5
============================================
- Hits 5273 5266 -7
+ Misses 24169 24082 -87
- Partials 482 485 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4759?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1913664601
I think the naming of `eventmesh-sdk-java-tcp` will be better than `eventmesh-tcp-sdk-java`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "scwlkq (via GitHub)" <gi...@apache.org>.
scwlkq commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1914589216
> Is it necessary to split java-sdk into so many modules?
Please provide some suggestions for splitting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "qqeasonchen (via GitHub)" <gi...@apache.org>.
qqeasonchen commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1914438817
too much sdks for users, doesn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "scwlkq (via GitHub)" <gi...@apache.org>.
scwlkq commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1914577683
The minimum granularity of the original Java-SDK was 'client'：http-client、grpc-client、tcp-client、workflow-client、catalog-client,so I split it according to this dimension to let each SDK have a single responsibility as much as possible.
But it seems bring some inconvenience，such as users should dependent on multiple SDKs if users want to use the feature, bring more sdks, etc.
The issue originally aims to split java sdk to multiple sdk by communication protocol, implement the slimming of the java sdk.. Maybe another method to reduce SDKs' number and meet issue's requirement is: put http, tcp, grpc individually(split by protocol), put other clients in one SDK.
cn：
原来Java SDK的最小粒度是‘客户端’：http客户端、grpc客户端、tcp客户端、workflow客户端、catalog客户端，所以我按照这个维度进行分割使各个SDK之间尽可能单一职责。
但是这种分法带来了一些问题，比如用户如果想使用多个协议，需要依赖多个SDK 以及带来了很多SDK 等等。
这个Issue原来的目的是按照协议分割Java SDK使得Java SDK更加精简。也许另外一种减少SDK数量并且满足issue要求的方法是：将grpc、http、tcp独立开（按照协议），将其他的客户端放在一个SDK下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1914546557
Is it necessary to split java-sdk into so many modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1917150379
What is the original intention of issue #1013?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE 1013] Java sdk split multiple sdk by communication protocol (eventmesh)
Posted by "scwlkq (via GitHub)" <gi...@apache.org>.
scwlkq commented on PR #4759:
URL: https://github.com/apache/eventmesh/pull/4759#issuecomment-1914227539
> I think the naming of `eventmesh-sdk-java-tcp` will be better than `eventmesh-tcp-sdk-java`. What do you think?
ye，I think your naming method looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org