You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "RapperCL (via GitHub)" <gi...@apache.org> on 2023/07/03 09:29:13 UTC
[GitHub] [dubbo] RapperCL opened a new issue, #12654: Metircs: I think the requestBeforeEvent in metrics may be redundant and needs to be optimized.
RapperCL opened a new issue, #12654:
URL: https://github.com/apache/dubbo/issues/12654
"RequestBeforeEvent" is a type of "RequestEvent" (which terminates execution) and should not be created as a new class as it is redundant and difficult to maintain.
If it is necessary to separately monitor this type of event, it is recommended to add the constant "INVOCATION_REQUEST_BEFORE" and provide the "isRequestBeforeEvent" method.
forexample:
add constant:
Add the toRequestBeforeEvent method：
Add the isRequestBeforeEvent method:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng commented on issue #12654: Metircs: I think the requestBeforeEvent in metrics may be redundant and needs to be optimized.
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on issue #12654:
URL: https://github.com/apache/dubbo/issues/12654#issuecomment-1618149216
多个类型 vs 多个常量
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] Metircs: I think the requestBeforeEvent in metrics may be redundant and needs to be optimized. [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ closed issue #12654: Metircs: I think the requestBeforeEvent in metrics may be redundant and needs to be optimized.
URL: https://github.com/apache/dubbo/issues/12654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org