[jira] [Issue Comment Edited] (CAMEL-4908) Twitter component fixes

["Claus Ibsen (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187673#comment-13187673 ] 

Claus Ibsen edited comment on CAMEL-4908 at 1/17/12 1:30 PM:
-------------------------------------------------------------

Bilgin you may want to read about checkstyle, so you can run a test to run a report on the command line, which tells you if the source code is aligned as it should (eg indent, parenthesis, and whatnot)

See building with checkstyle here:
http://camel.apache.org/building.html

And btw I do not think you need to create a new ArrayList when you guard it as unmodified, as the caller will not be able to modify the list.
Or did I miss a point? If so please add a code comment in the source why this is done as is
return Collections.unmodifiableList(new ArrayList(receivedStatuses));

                
      was (Author: davsclaus):
    Bilgin you may want to read about checkstyle, so you can run a test to run a report on the command line, which tells you if the source code is aligned as it should (eg indent, parenthesis, and whatnot)

See building with checkstyle here:
http://camel.apache.org/building.html

And btw I do not think you need to create a new ArrayList when you guard it as unmodified, as the caller will not be able to modify the list.
return Collections.unmodifiableList(new ArrayList(receivedStatuses));

                  
> Twitter component fixes
> -----------------------
>
>                 Key: CAMEL-4908
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4908
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-twitter
>    Affects Versions: 2.10.0
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: 2.10.0
>
>         Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira