You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/23 11:02:25 UTC
[jira] [Commented] (FLINK-3651) Fix faulty RollingSink Restore
[ https://issues.apache.org/jira/browse/FLINK-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208158#comment-15208158 ]
ASF GitHub Bot commented on FLINK-3651:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1830
[FLINK-3651] Fix faulty RollingSink Restore
On restore the sink for subtask index i has to cleanup leftover files
for subtask i. The pattern used for checking this was not properly
terminated so the sink for subtask 1 would, for example, delete some
files for sink i=11. This would lead to data loss.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink rolling-sink-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1830.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1830
----
commit a78d88f01a3d0da3bcfaad07c9abf419061a8025
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-03-07T16:15:20Z
[FLINK-3651] Fix faulty RollingSink Restore
On restore the sink for subtask index i has to cleanup leftover files
for subtask i. The pattern used for checking this was not properly
terminated so the sink for subtask 1 would, for example, delete some
files for sink i=11. This would lead to data loss.
----
> Fix faulty RollingSink Restore
> ------------------------------
>
> Key: FLINK-3651
> URL: https://issues.apache.org/jira/browse/FLINK-3651
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> The RollingSink restore logic has a bug where the sink for subtask index 1 also removes files for subtask index 11 because the regex that checks for the file name also matches that one. Adding the suffix to the regex should solve the problem because then the regex for 1 will only match files for subtask index 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)