You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 21:52:51 UTC
[GitHub] [airflow] gmsantos opened a new pull request, #24884: Upgrade FAB to 4.1.3
gmsantos opened a new pull request, #24884:
URL: https://github.com/apache/airflow/pull/24884
No relevant changes were found when comparing `airflow/www/fab_security` with the FAB source.
See https://github.com/dpgaspar/Flask-AppBuilder/compare/v4.1.2...v4.1.3
Ps.: I think that the constraints-main file needs to be updated somehow. Let me know if I need to handle this on this PR.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24884: Upgrade FAB to 4.1.3
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24884:
URL: https://github.com/apache/airflow/pull/24884#issuecomment-1176799295
BTW. I rebased it so that I can merge it tomorrow morning - I **just** merged a bit "bigger" requirement change (moving SQL classes to a new provider). So I want to make sure this one is run on -top of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24884: Upgrade FAB to 4.1.3
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24884:
URL: https://github.com/apache/airflow/pull/24884#issuecomment-1176836921
Both merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24884: Upgrade FAB to 4.1.3
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24884:
URL: https://github.com/apache/airflow/pull/24884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24884: Upgrade FAB to 4.1.3
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24884:
URL: https://github.com/apache/airflow/pull/24884#issuecomment-1176804916
But actually, you made me think - this is a good idea to bring such changes in a form of PR even if it's not automated yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24884: Upgrade FAB to 4.1.3
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24884:
URL: https://github.com/apache/airflow/pull/24884#issuecomment-1176810783
Linked PR with constraints: https://github.com/apache/airflow/pull/24886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmsantos commented on pull request #24884: Upgrade FAB to 4.1.3
Posted by GitBox <gi...@apache.org>.
gmsantos commented on PR #24884:
URL: https://github.com/apache/airflow/pull/24884#issuecomment-1176796395
thanks for the explanation @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24884: Upgrade FAB to 4.1.3
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24884:
URL: https://github.com/apache/airflow/pull/24884#issuecomment-1176793696
You can't update constraints in the same PR because constraints are in orphaned branch (constraints-main).
The Constraints main should be refreshed at merge time via https://github.com/apache/airflow/blob/main/dev/REFRESHING_CI_CACHE.md#manually-generating-constraint-files
This is only really needed when you have the == change (or otherwise chagne that introduces range of dependency that does not overlap with the previous range). This is the only case that is not (yet) handled automatically (it could be, but we would have to create a PR automatically to the `constraints-main` branch and let them be merged at the same time.
Effectively it means that the person (committer) who merges it, should prepare constraints just before merge and do the push at the same time as merge (either way it needs a bit synchronized action). You cannot push to the branch as you are not a committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org