You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/04/02 20:20:05 UTC

[GitHub] jthomas commented on issue #63: style: add .editorconfig, eslint and reformat js file

jthomas commented on issue #63: style: add .editorconfig, eslint and reformat js file
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-378032201
 
 
   👋 @ert78gb. Thanks for the updates to this PR, everything looks perfect to me now 💯. If you have other re-factoring suggestions, feel free to open PRs. FYI internal re-factoring is great but anything that changes the external API for cosmetic reasons is not likely to be considered for merging if that makes sense?
   
   @csantanapr Is your review now resolved?
   
   I agree with @csantanapr that this won't require a major version change as semver refers to the client libraries public API. I know in JS land people often use private methods but that's not something we manage through the semver version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services