You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by GitBox <gi...@apache.org> on 2020/07/15 06:56:21 UTC
[GitHub] [openjpa] eolivelli opened a new pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively
eolivelli opened a new pull request #66:
URL: https://github.com/apache/openjpa/pull/66
This is a draft PR.
I am trying to run all of the integration tests against HerdDB.
HerdDBDictionary enables aggressive use of delimiters, in order to not have problems with the the long list of reserved words in Apache Calcite.
TestPersistence fails and I am suggesting this fix.
If the fix is correct, can you please suggest me where to add a test case ?
Please note that this is not the only fix needed to run integration tests with HerdDB, I will follow up with other PRs or requests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] rmannibucau commented on pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #66:
URL: https://github.com/apache/openjpa/pull/66#issuecomment-658586585
This is what does the getColumnAlias in the enclosing class so it looks good to me, just requires to check all IT on all DB but I'm quite confident.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] eolivelli commented on pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #66:
URL: https://github.com/apache/openjpa/pull/66#issuecomment-659226910
GitHub does not allow me to reopen this PR, created #68 68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] eolivelli closed pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #66:
URL: https://github.com/apache/openjpa/pull/66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openjpa] eolivelli commented on pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #66:
URL: https://github.com/apache/openjpa/pull/66#issuecomment-658740170
@rmannibucau @struberg I am closing this PR, superseded by #67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org