You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "davebarnes97 (GitHub)" <gi...@apache.org> on 2019/02/27 20:06:32 UTC
[GitHub] [geode] davebarnes97 opened pull request #3244: GEODE-4794
User Guide - update description of `gfsh configure pdx` command.
[ Full content available at: https://github.com/apache/geode/pull/3244 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3244:
GEODE-4794 User Guide - update description of `gfsh configure pdx` command.
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
I don't have much experience on what `configure PDX` do. The actual help text probably needs to be looked by the person in the storage?
[ Full content available at: https://github.com/apache/geode/pull/3244 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] davebarnes97 commented on pull request #3244:
GEODE-4794 User Guide - update description of `gfsh configure pdx` command.
Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
Don't worry, no code changes needed - earlier work on this JIRA ticket took care of that.
This PR addresses some of the wording, just trying to make it more precise.
[ Full content available at: https://github.com/apache/geode/pull/3244 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] joeymcallister commented on pull request #3244:
GEODE-4794 User Guide - update description of `gfsh configure pdx` command.
Posted by "joeymcallister (GitHub)" <gi...@apache.org>.
I think there's a word missing here. Maybe either "so it should be issued" or "and so should be issued."
Other than that, this LGTM. +1
[ Full content available at: https://github.com/apache/geode/pull/3244 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3244:
GEODE-4794 User Guide - update description of `gfsh configure pdx` command.
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
If this is copied from the command help, then I am fine with it. If not, then we will need to change the code to match this.
[ Full content available at: https://github.com/apache/geode/pull/3244 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] joeymcallister commented on pull request #3244:
GEODE-4794 User Guide - update description of `gfsh configure pdx` command.
Posted by "joeymcallister (GitHub)" <gi...@apache.org>.
I think there's a word missing here. Maybe either "so it should be issued" or "and so should be issued."
[ Full content available at: https://github.com/apache/geode/pull/3244 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] davebarnes97 closed pull request #3244: GEODE-4794
User Guide - update description of `gfsh configure pdx` command.
Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
[ pull request closed by davebarnes97 ]
[ Full content available at: https://github.com/apache/geode/pull/3244 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org