You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/08/19 02:57:14 UTC

[jira] Created: (CASSANDRA-376) sanity check start, finish slice args

sanity check start, finish slice args
-------------------------------------

                 Key: CASSANDRA-376
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
            Priority: Minor


we should validate that

 - start and finish are both valid values for the comparator in the given CF
 - finish >= start


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-376) sanity check start, finish slice args

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-376:
-------------------------------------

    Fix Version/s: 0.4

> sanity check start, finish slice args
> -------------------------------------
>
>                 Key: CASSANDRA-376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.4
>
>
> we should validate that
>  - start and finish are both valid values for the comparator in the given CF
>  - finish >= start

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-376) sanity check start, finish slice args

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744871#action_12744871 ] 

Jun Rao commented on CASSANDRA-376:
-----------------------------------

For reverse ordering, finish <= start.

> sanity check start, finish slice args
> -------------------------------------
>
>                 Key: CASSANDRA-376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>
> we should validate that
>  - start and finish are both valid values for the comparator in the given CF
>  - finish >= start

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-376) sanity check start, finish slice args

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated CASSANDRA-376:
-------------------------------------

    Component/s: Core

> sanity check start, finish slice args
> -------------------------------------
>
>                 Key: CASSANDRA-376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>
> we should validate that
>  - start and finish are both valid values for the comparator in the given CF
>  - finish >= start

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-376) sanity check start, finish slice args

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744821#action_12744821 ] 

Jonathan Ellis commented on CASSANDRA-376:
------------------------------------------

also, column name validation is being performed by CF/SC.  this is wrong; we don't want to re-validate all the times those are called internally; only when first loading data from the client.

there is no SC/column name validation being done on reads at all right now.

> sanity check start, finish slice args
> -------------------------------------
>
>                 Key: CASSANDRA-376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>
> we should validate that
>  - start and finish are both valid values for the comparator in the given CF
>  - finish >= start

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-376) sanity check start, finish slice args

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745937#action_12745937 ] 

Hudson commented on CASSANDRA-376:
----------------------------------

Integrated in Cassandra #174 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/174/])
    sanity check start, finish slice args
patch by jbellis; reviewed by Evan Weaver for 


> sanity check start, finish slice args
> -------------------------------------
>
>                 Key: CASSANDRA-376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: 376.patch
>
>
> we should validate that
>  - start and finish are both valid values for the comparator in the given CF
>  - finish >= start

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-376) sanity check start, finish slice args

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-376:
-------------------------------------

    Attachment: 376.patch

add tests and validation code

> sanity check start, finish slice args
> -------------------------------------
>
>                 Key: CASSANDRA-376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: 376.patch
>
>
> we should validate that
>  - start and finish are both valid values for the comparator in the given CF
>  - finish >= start

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-376) sanity check start, finish slice args

Posted by "Evan Weaver (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745478#action_12745478 ] 

Evan Weaver commented on CASSANDRA-376:
---------------------------------------

ship it!

> sanity check start, finish slice args
> -------------------------------------
>
>                 Key: CASSANDRA-376
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-376
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: 376.patch
>
>
> we should validate that
>  - start and finish are both valid values for the comparator in the given CF
>  - finish >= start

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.