You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by yuri1969 <gi...@git.apache.org> on 2017/08/13 19:59:49 UTC
[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...
GitHub user yuri1969 opened a pull request:
https://github.com/apache/nifi/pull/2081
NIFI-3780 - Should be able to specify Service...
...name when I create a new Controller Service within a Processor/Service configuration dialog
I'm not sure how to integrate/style the text box. Suggestions are welcome.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuri1969/nifi NIFI-3780
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2081
----
commit 47acf746b8b7bb8c7250c9a87db530ed01d80392
Author: yuri1969 <19...@gmail.com>
Date: 2017-08-13T18:15:38Z
NIFI-3780 - Should be able to specify Service...
...name when I create a new Controller Service within a Processor/Service configuration dialog
I'm not sure how to integrate/style the text box. Suggestions are welcome.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2081
@scottyaslan – agreed, likely a larger and separate effort to know all existing CSs. I'll create a new jira to capture the idea.
I think your suggestion as a first step is a good one. One thing I would recommend is that the CS Name field be placed _after_ the Compatible CS dropdown since the default name will be dependent of the user's Compatible CS selection.
And just to add more complexity ;) – if the user edits the default name and then goes back to choose a different Compatible CS, I'd recommend leaving the user-entered name as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...
Posted by yuri1969 <gi...@git.apache.org>.
GitHub user yuri1969 reopened a pull request:
https://github.com/apache/nifi/pull/2081
NIFI-3780 - Should be able to specify Service...
...name when I create a new Controller Service within a Processor/Service configuration dialog
I'm not sure how to integrate/style the text box. Suggestions are welcome.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuri1969/nifi NIFI-3780
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2081
----
commit 47acf746b8b7bb8c7250c9a87db530ed01d80392
Author: yuri1969 <19...@gmail.com>
Date: 2017-08-13T18:15:38Z
NIFI-3780 - Should be able to specify Service...
...name when I create a new Controller Service within a Processor/Service configuration dialog
I'm not sure how to integrate/style the text box. Suggestions are welcome.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Posted by yuri1969 <gi...@git.apache.org>.
Github user yuri1969 commented on the issue:
https://github.com/apache/nifi/pull/2081
OK, @scottyaslan and @moranr. I'll try to push an update tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Posted by yuri1969 <gi...@git.apache.org>.
Github user yuri1969 commented on the issue:
https://github.com/apache/nifi/pull/2081
A misclick, sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2081
@moranr I am not sure we could do that (currently) without the UI knowing how many CS's are named 'StandardSSLContextService-*' . I think that would require a bit more effort to create some REST endpoints etc. Maybe for this iteration we can just move the new CS name field up above the 'Compatible Controller Services' drop down and use the class name of the selected CS in the 'Compatible Controller Services' drop down as the default name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2081
This will be a nice addition from a usability perspective.
It could be helpful to go ahead and generate a default name for the service following some type of simple naming convention (e.g., StandardSSLContextService**-1**, StandardSSLContextService**-2**, and so on). This would actually be helpful to follow for _any_ controller service that is created, not just if it is created via a processor/service configuration dialog.
I also notice in the dialog that the name field is at the bottom of the dialog and not seen unless scrolled to. It would be helpful see that field at or near the top so the user can immediately relate to the new service by its name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2081
Thanks @yuri1969 this has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2081
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...
Posted by yuri1969 <gi...@git.apache.org>.
Github user yuri1969 closed the pull request at:
https://github.com/apache/nifi/pull/2081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---