You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/07 15:44:17 UTC

[GitHub] [spark] srowen commented on a change in pull request #24544: [SPARK-27563][FOLLOWUP][HOTFIX] Fix to download new release from `dist.apache.org`

srowen commented on a change in pull request #24544: [SPARK-27563][FOLLOWUP][HOTFIX] Fix to download new release from `dist.apache.org`
URL: https://github.com/apache/spark/pull/24544#discussion_r281698695
 
 

 ##########
 File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
 ##########
 @@ -210,11 +211,12 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {
 }
 
 object PROCESS_TABLES extends QueryTest with SQLTestUtils {
+  val releaseMirror = "https://dist.apache.org/repos/dist/release"
   // Tests the latest version of every release line.
   val testingVersions: Seq[String] = {
     import scala.io.Source
     try {
-      Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString
+      Source.fromURL(s"${releaseMirror}/spark").mkString
 
 Review comment:
   If we're picking nits and you change it again, it's not really a mirror. It's the primary dist server. `asfDist` or something.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org