You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/09 18:00:28 UTC

[GitHub] [superset] AAfghahi commented on pull request #14956: chore: Add height/width TrashIcon SVG(18px/18px)-Edit Dataset modal

AAfghahi commented on pull request #14956:
URL: https://github.com/apache/superset/pull/14956#issuecomment-857919804


   > > This looks good! Thank you!
   > > small nit: did you try it with iconSize="s"?
   > 
   > I did try that on the `<Icon.Trash>`, but it made the icon smaller. Am I missing something?
   
   hmm, it might be fontSize 12. In which case this is probably the ideal solution. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org