You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Karuppayya <gi...@git.apache.org> on 2015/07/14 08:59:55 UTC
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
GitHub user Karuppayya opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/156
The user will be able to provide a name to note at creation time
Ability to name a note while creating from UI. By default a name is shown. User can change that name. If user does not provide any name then we randomly name it at backend like the way its happening right now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Karuppayya/incubator-zeppelin notename
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit 0a7db2b08e59c52645c3ba229d6b7f8d5c245441
Author: Karuppayya <ka...@outlook.com>
Date: 2015-07-14T06:54:15Z
The user will be able to provide a name to note at creation time
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-123994032
Thanks @corneadoug
I have renamed the directive, since it is specific to visibility of the modal.(Moreover it depends on bootstrap modal events).
Also,Provisioning of callbacks is nice idea.
I have made changes for the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127039814
@corneadoug I have provided option for configuring the id of input whose text should be elected.
If the id is not provided, there will be no input text selection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125067718
Hi, Thanks for the nice improvement. Clicking 'Create new note' displays dialog, but it does not update note name for me. Always created with default name in my browser.
And i can see two errors in my javascript console.
<img width="1226" alt="screen shot 2015-07-27 at 11 42 32 am" src="https://cloud.githubusercontent.com/assets/1540981/8897695/a60438ee-3454-11e5-915f-c4ab2c96c5a8.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-122138299
The tests have been fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-121252201
Hi,
Thanks for the PR,
Can you please also provide a screenshot? Its always better when there is changes on the web part :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-124004063
Just left a few more comments.
I will do a final test, to be sure everything is working once its done.
I'm not sure ``$('#noteName').select();`` is really necessary, mainly because dom modification code should not be inside a controller. Using ``autofocus`` directive might have the same effect. Otherwise, using angular.element syntax would be better if you think it is essential.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127142565
Thanks @corneadoug . Will i be provided access for merge? or what is the process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127791438
This is how i tested
```
git clone https://github.com/Karuppayya/incubator-zeppelin.git
cd incubator-zeppelin/
git checkout notename
mvn package -DskipTests
bin/zeppelin-daemon.sh start
```
Clear browser cache and connect to localhost:8080. And then click 'create new note' button.
I still can see the error on chrome 44.0.2403.130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127709612
Not getting anything either. (I always do a git clean -dxf)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125503275
Tests are passing, but the commit history is weird (event in github graph).
Also I guess you didn't rebase, ng-delete should not be there anymore
https://github.com/apache/incubator-zeppelin/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125831645
Thanks for the changes, I will check the code and test it again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-129646840
how to fix the following jshint error ?
src/components/noteName-create/visible.directive.js
[INFO] line 33 col 13 '$' is not defined.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-129130320
Tested, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125249953
I am not able to run the selenium tests locally . But from the build logs look like something related to "paragraph" is failing.(Not sure why my change is affecting something related to paragraph) Can someone have a quick look.
Also it would be great if you could point out the version of selenium and browser driver version used by travis ..(been having hard time :-) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-129099842
<img width="1269" alt="screen shot 2015-08-09 at 08 36 21" src="https://cloud.githubusercontent.com/assets/5082742/9153420/33649a90-3e72-11e5-93c0-5752f9a0ad3e.png">
@Leemoonsoo I am using the same version of chrome and i dont see the error.
I am just guessing whether it could be caused due to some chrome extension.
Can we try this once in a private window whether extensions are not enabled.
@corneadoug are you also this error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125091867
I am not very sure about the first js error. I have not changed anythong on that front.
And it works just fine in my local setupo.
As for the seconfd js err ("cross origin request..."), I have fixed it.
Please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127150186
After enough PPMC vote for the merge, one of them will be merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125520007
Apologies for the bad merge.(Yes, I did rebase ).
The build error is as follows
09:06:59,470 INFO org.apache.commons.httpclient.HttpMethodDirector:445 - Retrying request
09:06:59,470 INFO org.apache.commons.httpclient.HttpMethodDirector:439 - I/O exception (java.net.ConnectException) caught when processing request: Connection refused
Is this a known issue.?
If its intermittent, can we restart the build for this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-129129537
@Leemoonsoo my fault.. just now realised that note can be created from two place.(from navbar and link on home page). I have now fixed the js error in the home page link as well in https://github.com/Karuppayya/incubator-zeppelin/commit/02e60732288d3dcf2ba937e274322db3d3bd3e35
Could you please try now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-126560877
@corneadoug does the change looks good?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127133210
Awesome, looks good to merge.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-126879211
@karuppayya sorry, I'm currently traveling and I have a hard time having some internet connection. I should be able to check it out in the next 24h
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-123232193
It's a nice contribution, and I left a few comments in the code.
I like the fact that you used vm in the controller. However the directive/controller combo can be improved.
* Either by making visible directive general (taking a callback function), and moving all the scope part back to the controller (vm)
* Either by making a createNewNote directive, and deleting the ``note-name-dialog.html` file and note-``name.controller.js`` files
I'm also getting this:
``XMLHttpRequest cannot load javascript:void(0);. Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, https, chrome-extension-resource.``
when I click on new notebook for the first time after page load, any idea? (coming from jquery.js)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-121283721
Hi @corneadoug ,
I have attached it in this comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-122149429
Thanks,
I will take a look at your PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125526608
If you close/reopen the PR, it will launch the CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127642530
@Leemoonsoo I had this fixed in https://github.com/Karuppayya/incubator-zeppelin/commit/606282aaec74abd4da96a084f7f174ab1dd0bdcd
I am not seeing the error in my setup.
Can u please clear cache and try once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-129101141
@Karuppayya
I just tried again with disabling all chrome extension, with private window but still getting the same error.
I also tried with Safari and see the same error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-125550534
@corneadoug Thanks for letting me know.
Sorry about the bad merge earlier.
Found couple of js warnings during build time, fixed them as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: The user will be able to provide ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-127544317
I've tested and everything works fine, but i still get an error on javascript console.
Can we remove this error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---